Re: [PATCH (REVISED)] Add core.editor configuration variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Jul 19, 2007, at 3:48 AM, Andy Parkins wrote:

On Thursday 2007 July 19, Adam Roben wrote:

   Well, it turns out we already do launch an editor in other places,
namely "git am -i" and "git send-email --compose". So, this patch takes
care of those cases as well.

Perhaps I'm being overly pedantic, but it seems odd to put options that are
relevant only to porcelain under the "core" section.

core.pager is in the same category - but that's already in.

Since I'm the one who added that, I feel compelled to add in my $0.02.

First, there wasn't much argument on the list when core.pager was added... But that's not my major point.

To many git users (myself included), claiming that commands like git- commit, git-log, and other "porcelain" isn't part of "core" git is ridiculous. These are the commands that I use every day, and are a part of the main git package, source, and repository. If the porcelain was maintained separately from the pluming, like cognito was, perhaps that would be a more compelling argument to me.

For many people commit is more "core" to their git usage than write- tree and commit-tree. At this point, it's less an extra layer porcelain and more the standard interface. It's a result of the wonderful attempts to make git more user friendly.

As far as [core] being only for plumbing, I disagree with that premise as well. Any option that is used across many of the git commands is a core (meaning central) option.

~~ Brian
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux