On Fri, Aug 16, 2019 at 3:01 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Elijah Newren <newren@xxxxxxxxx> writes: > > > write_tree_from_memory() appeared to be a merge-recursive special that > > basically duplicated write_index_as_tree(). The two have a different > > signature, but the bigger difference was just that write_index_as_tree() > > would always unconditionally read the index off of disk instead of > > working on the current in-memory index. So: > > > > * split out common code into write_index_as_tree_internal() > > > > * rename write_tree_from_memory() to write_inmemory_index_as_tree(), > > Somewhat minor, but I find "inmemory_index" hard to see while > scanning the patch. Perhaps call it "in_core_index" instead? > > I originally started the above with "Very minor, ...", but as this > is exposed to the public in a header file, the name matters a bit > more than that. Sounds good; will change.
