On Mon, Aug 12, 2019 at 5:14 AM René Scharfe <l.s.r@xxxxxx> wrote: > > That looks like an issue worth its own commit. OK, but then will make my topic interesting; indeed it almost feels like it should be 3 different topics all depending of each other in a chain: * really use the match context * move to xmalloc (2 patches, one for each PCRE library) * fix leak Which then will conflict with ab/pcre-jit-fixes before it can get merged to pu > I wonder if we'd want to pass pcre2_match_context to pcre2_match() a few > lines down as well, for consistency. yes, that is actually what was tested[1] as can be seen in github where Dscho integration did most of the heavy lifting with Windows Carlo [1] https://github.com/git/git/pull/627
