On 8/7/19 11:20 PM, Junio C Hamano wrote:
Pratyush Yadav <me@xxxxxxxxxxxxxxxxx> writes:
So if I fork the project, will you pull from my fork? If yes, what
exactly would I have to do? Make a set of changes and then ask on the
list for you to pull from my fork?
I am a relatively inexperienced programmer, and it feels like a kinda
big responsibility that I'm not sure I am ready for. But maybe you can
look at the changes from a high level POV before pulling, so there is
someone sanity checking my changes.
This patch as a one-off thing may not be too bad, as it already had
exposure to the list (and there probably are more people scanning it
than it would have been if you silently made a pull request on
GitHub, because they saw messages from me in this thread).
I think you misunderstood me. I do not mean to create a GitHub pull
request, because as you say, no one other than me and you will look at
it. What I meant was that I can pile up a bunch of commits, and send
them on this list here for you to merge. I can explain those changes in
the cover letter, so people not very familiar with git-gui or Tcl/Tk can
still get a general idea of what's happening.
BUT.
If I make it a habit to pull git-gui stuff from random people who
are not committed to and/or feel experienced enough for working on
git-gui, the result would be even worse than taking patches on
git-gui directly from the list. At least a patch on the list I can
see how others react (or not react). On the other hand, I do not
know how to interpret lack of comments from others on GitHub pull
request---perhaps nobody thought it was a good change, perhaps
nobody is paying attention to it, or what other possibilities there
are.
So,... quite honestly, I'd rather not.
I'm not sure what the bottom line is for what you say. Does this mean
that you'd rather not merge patches about git-gui at all, and if I want
to improve something, I should just run my own fork (at least until
someone steps up to maintain it)? Or does this mean that you'd prefer me
to send patches here on this list, and you'd look at them and merge
them? Or is it something else?
And again, to make it clear, I do not intend to use GitHub pull requests
at all. What I meant by "pull from me" was just that you pull (maybe
fetch is the right word?) changes from my fork and merge them in your
tree. But as you said, you'd rather not.
--
Regards,
Pratyush Yadav
