On 2019-08-03 at 23:52:08, KADOTA, Kyohei via GitGitGadget wrote: > I ported git, and git subcommands only written in C to Plan 9. This pull > request contains patches for existing codes, and new files to build git in > Plan 9. > > All build options such as NO_PERL are not supported yet, and also some git > subcommands written not in C is not available yet. But git can synchronize > to remote repository with git pull and git push via HTTPS. > > This pull request don't contain a part of Git toolchain for example > git-credential-store, etc. So I'm going to port other parts of Git toolchain > too in the future. This series seems to build a whole new build system that uses Plan 9 tools. Typically the way ports to non-POSIX platforms (such as Windows) have been handled is that the Unix tools, including GNU make, have been ported to those platforms, and the POSIX (or POSIX-ish) environment used there. I'm concerned that by introducing a whole bunch of new, Plan 9-specific build code, we're going to have it fall behind with features or bug fixes, because none of the main developers test on Plan 9, and most contributors will not have the Plan 9 skills or systems to maintain the code. In addition, the editor used by git commit and other commands invokes "sh", but you've set this to "rc". That's completely different from the way that all other environments work, and it means that Git on Plan 9 operates in a totally different, incompatible way there. We also use a POSIX shell for the testsuite, and we rely on it quite heavily. rc is not going to cut it there. Plan 9 has a POSIX environment, and I think it might be a better idea to require that as a condition for building and running Git. It will likely be a lot easier, at least. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
