Hi, On Wed, 18 Jul 2007, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > +this_script="$(cd "$(dirname "$0")"; pwd)"/$(basename "$0") > > ... > > + filter_commit="SOURCE_FUNCTIONS=1 . \"$this_script\"; $OPTARG" > > Hmmmmmm. > > Care to enlighten why this is not just: > > filter_commit="SOURCE_FUNCTIONS=1 . \"$0\"; $OPTARG" > > Is it because you cd(1) around in the script, and it can be > relative to where you started? Yes. > In either case, are you quoting potential funnies (such as '"' > or '\\') in "$0" sufficiently? Exporting this_script variable, > and changing the above to > > filter_commit='SOURCE_FUNCTIONS=1 . "$this_script";'" $OPTARG" > > to arrange the shell that is invoked with 'sh -c' to expand its > value would make it smaller problem, I suspect. Will do. You know, I do have my problems with correct quoting, and the way I did it in this patch was always good enough for me. Which does not mean much... Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
