Hi, On Wed, 31 Jul 2019, Ariadne Conill wrote: > Hello, > > On Wed, Jul 31, 2019 at 10:21 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > > Jeff King <peff@xxxxxxxx> writes: > > > > > This seems OK to me, though I kind of wonder if anybody really wants > > > "auto". Unlike log.decorate, which changes the syntax, there is no real > > > reason to avoid mailmap when somebody else is parsing the output. And I > > > could imagine it is especially confusing if: > > > > > > git log --author=whoever > > > > > > and > > > > > > git log | grep whoever | wc -l > > > > > > do not agree. > > > > I personally do not think it is too late to change for the upcoming > > release, either. > > > > But 'auto' that changes the displayed name depending on the output > > being or not being a terminal makes little sense, I would think, for > > the above reason. > > > > I think if the warning is annoying people, then we should just change > the default and document it in the release notes. Ultimately, I think > that this is behaviour that most see as a bug (especially when you > consider that `git shortlog` and `git blame` default to using mailmap > already), so simply describing it as a bugfix is arguably sufficient. I also agree! And it makes me happy not only because I am no longer annoyed by that warning that flickers before the pager kicks in, but even happier because I know people who used to be known by another name that they really do not care about anymore. Thanks, Dscho
