On 7/31/2019 11:01 AM, Ævar Arnfjörð Bjarmason wrote: > > On Tue, Jul 30 2019, Derrick Stolee via GitGitGadget wrote: > >> +feature.*:: >> + The config settings that start with `feature.` modify the defaults of >> + a group of other config settings. These groups are created by the Git >> + developer community as recommended defaults and are subject to change. >> + In particular, new config options may be added with different defaults. >> + >> +feature.manyCommits:: >> + Enable config options that optimize for repos with many commits. This >> + setting is recommended for repos with at least 100,000 commits. The >> + new default values are: >> ++ >> +* `core.commitGraph=true` enables reading the commit-graph file. >> ++ >> +* `gc.writeCommitGraph=true` enables writing the commit-graph file during >> +garbage collection. > > During the whole new commit graph format discussion (which has now > landed) we discussed just auto toggling this: > https://public-inbox.org/git/87zhobr4fl.fsf@xxxxxxxxxxxxxxxxxxx/ > > This looks fine, but have we backed out of simply enabling this at this > point? I don't see why not, regardless of commit count... I would be happy to drop feature.manyCommits and instead swap the defaults of core.commitGraph and gc.writeCommitGraph to true if we think that is what we want to do for 2.24.0. We can use the repo settings and UPDATE_DEFAULT[_BOOL] for this purpose. Thanks, -Stolee
