On Thu, Aug 01, 2019 at 05:53:09PM +0200, SZEDER Gábor wrote: > Subject: Re: [PATCH 3/3] tests: warn against appending non-httpd-specific > tests at the end This subject line kind of sucks, doesn't it?! Alas I had a bit of a hard time coming up with something better. So far the best (well, least bad) I could think of is: t: warn against adding non-httpd-specific tests after sourcing 'lib-httpd' > We have a couple of test scripts that are not completely > httpd-specific, but do run a few httpd-specific tests at the end. > These test scripts source 'lib-httpd.sh' somewhere mid-script, which > then skips all the rest of the test script if the dependencies for > running httpd tests are not fulfilled. > > As the previous two patches in this series show, already on two > occasions non-httpd-specific tests were appended at the end of such > test scripts, and, consequently, they were skipped as well when httpd > tests couldn't be run. > > Add a comment at the end of these test scripts to warn against adding > non-httpd-specific tests at the end, in the hope that they will help > prevent similar issues in the future.
