On Tue, Jul 30, 2019 at 09:33:27PM +0100, Dmitry Safonov wrote: > @@ -589,6 +591,19 @@ test_expect_success $PREREQ 'In-Reply-To with --chain-reply-to' ' > test_cmp expect actual > ' > > +test_expect_success $PREREQ 'ask confirmation for double-send' ' > + clean_fake_sendmail && > + echo y | \ > + GIT_SEND_EMAIL_NOTTY=1 \ > + git send-email --from=author@xxxxxxxxxxx \ > + --to=nobody@xxxxxxxxxxx \ > + --smtp-server="$(pwd)/fake.sendmail" \ > + --validate \ > + $patches $patches $patches \ > + >stdout && > + ! test_i18ngrep "Patches specified several times: " stdout You should write this as 'test_i18ngrep ! <...>'. When running the test with GIT_TEST_GETTEXT_POISON=true, then 'test_i18ngrep' is basically a noop and always returns with success, the leading ! would turn that into a failure, which then would fail the test. Sorry for not being specific enough.
