On 2019.07.29 22:09, Martin Ågren wrote: > On Fri, 19 Jul 2019 at 01:56, Josh Steadmon <steadmon@xxxxxxxxxx> wrote: > > * Martin's objection on 1/4 that the sample hook would always exit > > successfully is (I believe) incorrect. To test this, I ran > > "/bin/true && exec test 0 == 1" in a /bin/sh subshell, and it > > correctly had a non-zero exit status. > > I retract my comment on this. It was incorrect, indeed. > > > git-merge: Honor pre-merge hook > > Nit: s/H/h/ Fixed in V3. > > merge: do no-verify like commit > > Nit (maybe just me): this could be patch 1/N, before getting started > with the real focus of this series. Agreed, I found the ordering strange as well, but wanted to keep it the same as V1 to start with. Fixed in V3. > > > Martin
