On Fri, Jul 26, 2019 at 8:09 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > It will also implicitly re-enable UTF-8 validation for PCRE v1. As > noted in [1] we now have cases as a result where PCRE v1 is more eager > to error out. Subsequent patches will fix that for v2, and I think > it's fair to tell v1 users "just upgrade" and not worry about that > edge case for v1. > > 1. https://public-inbox.org/git/CAPUEsphZJ_Uv9o1-yDpjNLA_q-f7gWXz9g1gCY2pYAYN8ri40g@xxxxxxxxxxxxxx/ Haven't seen any responses from packagers but there was a report[1] of CentOS 6 users that would be affected, and would certainly make things more difficult to whoever is behind the git binary that comes with Xcode in macOS and that is linked against a system library (PCRE1) that is IMHO unlikely to be upgraded. The minimum I would expect if you want to move forward with this, would be to make their git not randomly die because of non UTF-8 haystack by applying [2] and make clear we will also introduce stack size problems like the one in [3] (as it was done in the previous commit) Feedback on the patchset[4] that applies on top of this to make sure JIT can be disabled at compile time and the logic is less messy also appreciated. Let me know also how you want to keep it on sync, as IMHO makes more sense inside your branch instead of as an independent topic. Carlo CC +Brian [1] https://public-inbox.org/git/20190615191514.GD8616@xxxxxxxxxxxxxxxxxxxxxxxxxx/ [2] https://public-inbox.org/git/20190722144350.46458-1-carenas@xxxxxxxxx/ [3] https://public-inbox.org/git/CAPUEspjj+fG8QDmf=bZXktfpLgkgiu34HTjKLhm-cmEE04FE-A@xxxxxxxxxxxxxx/ [4] https://public-inbox.org/git/20190726202642.7986-1-carenas@xxxxxxxxx/
