Hi Stolee, On Wed, 24 Jul 2019, Derrick Stolee via GitGitGadget wrote: > Updates in V2: I'm responding to Dscho's comments early, as they were very > valuable. > > * Rearranged how we are checking for the feature.* settings, so if one > layer turns the setting on and a later layer turns it off, we do not > adjust the defaults. > > > * Switched to using enums for the non-boolean config options. > > > * Placed the repo_settings struct directly in the repository struct. > > > * All struct members are initialized to -1 using memset. > > > * The config changes around directory rename detection is greatly > simplified. I left only a couple of comments, and quite honestly, I am really happy with the direction this is going. It even leaves the door open to let users define their custom feature groups, at least I have a couple of ideas how that could be accomplished building on top of `repo-settings.c`. Thanks! Dscho
