Hi Emily, On Mon, 1 Jul 2019, Emily Shaffer wrote: > Since v2, mostly reworded comments, plus fixed the issues mentioned in > the tutorial itself. Thanks Eric for the review. > > Emily Shaffer (13): > walken: add infrastructure for revwalk demo > walken: add usage to enable -h > walken: add placeholder to initialize defaults > walken: add handler to git_config > walken: configure rev_info and prepare for walk > walken: perform our basic revision walk > walken: filter for authors from gmail address > walken: demonstrate various topographical sorts > walken: demonstrate reversing a revision walk list > walken: add unfiltered object walk from HEAD > walken: add filtered object walk > walken: count omitted objects > walken: reverse the object walk order > > Makefile | 1 + > builtin.h | 1 + > builtin/walken.c | 297 +++++++++++++++++++++++++++++++++++++++++++++++ Since this is not really intended to be an end user-facing command, I think it should not become a built-in, to be carried into every Git user's setup. Instead, I would recommend to implement this as a test helper. This would have the following advantages: - it won't clutter the end user installations, - it will still be compile-tested with every build (guaranteeing that the tutorial won't become stale over time as so many other tutorials), - it really opens the door very wide to follow up with another tutorial to guide new contributors to write stellar regression tests. Thanks, Dscho > git.c | 1 + > 4 files changed, 300 insertions(+) > create mode 100644 builtin/walken.c > > -- > 2.22.0.410.gd8fdbe21b5-goog > > >
