On Tue, Jul 23, 2019 at 09:49:44AM -0700, Junio C Hamano wrote: > I think a change like this would impact kernel.org folks' tarball > uploading tool, but that is not a reason not to apply this patch. That was my thought, too. Distro projects like homebrew rely on stable hashes of upstream tarballs, and they get cranky when those tarballs change. Ideally the projects they package would provide byte-stable tarballs, but many of them rely on on-the-fly tarball generation by hosting sites like GitHub. Which isn't to say we should never fix bugs in the tarballs that we produce, but it's not entirely clear to me that this _is_ a bug, and not just one tool being overly picky. -Peff
