On Fri, Jul 19, 2019 at 01:27:38PM -0700, Junio C Hamano wrote: > * jk/test-commit-bulk (2019-07-02) 7 commits > - SQUASH??? > - t6200: use test_commit_bulk > - t5703: use test_commit_bulk > - t5702: use test_commit_bulk > - t3311: use test_commit_bulk > - t5310: increase the number of bitmapped commits > - test-lib: introduce test_commit_bulk > > A test helper has been introduced to optimize preparation of test > repositories with many simple commits, and a handful of test > scripts have been updated to use it. > > Needs a bit more polishing. > I think I spotted one unused command, which we may want to remove, though. I think these comments are out-of-date. The unused command was fixed up in v2 of the first patch, and then I did a little extra polishing in v3: https://public-inbox.org/git/20190702051649.GA16344@xxxxxxxxxxxxxxxxxxxxx/ Together with your SQUASH fixup, I think that covers all comments. For convenience, here's v3 again as a whole series which can replace what you have already (including the squash). [1/6]: test-lib: introduce test_commit_bulk [2/6]: t5310: increase the number of bitmapped commits [3/6]: t3311: use test_commit_bulk [4/6]: t5702: use test_commit_bulk [5/6]: t5703: use test_commit_bulk [6/6]: t6200: use test_commit_bulk t/t3311-notes-merge-fanout.sh | 10 +-- t/t5310-pack-bitmaps.sh | 15 +--- t/t5702-protocol-v2.sh | 10 +-- t/t5703-upload-pack-ref-in-want.sh | 4 +- t/t6200-fmt-merge-msg.sh | 7 +- t/test-lib-functions.sh | 123 +++++++++++++++++++++++++++++ 6 files changed, 136 insertions(+), 33 deletions(-) -Peff