Junio C Hamano wrote:
> We do allow a few selected C99 constructs in our codebase these
> days, but this is not among them (yet).
>
> Reported-by: Carlo Arenas <carenas@xxxxxxxxx>
> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
> ---
> transport.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Yes, gcc 4.8 fails to build without this:
transport.c:1234:4: error: ‘for’ loop initial declarations are only allowed in C99 mode
for (struct ref *it = remote_refs; it; it = it->next)
^
transport.c:1234:4: note: use option -std=c99 or -std=gnu99 to compile your code
Arguably it would be nice to use -std=gnu99 for better consistency
between gcc versions, but it's moot here: avoiding the declaration in
for loop initializer is more consistent with
-Wdeclaration-after-statement anyway.
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
Thanks.
