On Wed, Jul 10, 2019 at 3:58 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > Hi Junio, > > > > On Tue, 9 Jul 2019, Junio C Hamano wrote: > > > >> * mt/dir-iterator-updates (2019-06-25) 10 commits > >> - clone: replace strcmp by fspathcmp > >> - clone: use dir-iterator to avoid explicit dir traversal > >> - clone: extract function from copy_or_link_directory > >> - clone: copy hidden paths at local clone > >> - dir-iterator: add flags parameter to dir_iterator_begin > >> - dir-iterator: refactor state machine model > >> - dir-iterator: use warning_errno when possible > >> - dir-iterator: add tests for dir-iterator API > >> - clone: better handle symlinked files at .git/objects/ > >> - clone: test for our behavior on odd objects/* content > >> > >> Adjust the dir-iterator API and apply it to the local clone > >> optimization codepath. > >> > >> Is this ready for 'next'? > > > > I am afraid that still, just like I said in response to the previous > > "What's cooking" mail, this is not ready (which is unsurprising, given > > that it has not changed): it breaks 1,384 test cases. > > Let's kick it out of 'pu' for now to help ci runs on Windows, which > would be swamped with failures from this. Thanks for reminding me. Sorry for the delay. I just sent v8[1] with Dscho's suggestions, which should fix all those test failures on Windows. Thanks, Matheus [1]: https://public-inbox.org/git/cover.1562801254.git.matheus.bernardino@xxxxxx/
