Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx>
writes:

> From: Johannes Schindelin <johannes.schindelin@xxxxxx>
>
> A `+` is not a valid part of a filename with Windows file systems (it is
> reserved because the `+` operator meant file concatenation back in the
> DOS days).

The title of the cover letter had "windows" in it, so calling '+'
illegal was OK, but this patch does not.

I'd rather not to take this patch, because "generate in the target
with plus appended, make sure it succeeds, and then rename it to the
real target" is quite an established pattern not limited to the
Documentation/ directory of this project, if your tooling has been
supporting it and can continue to do so (which was the impression I
got from the cover letter).  Even the top-level .gitignore file
knows about it, so does the top-level Makefile and it uses the same
pattern.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux