Jeff King <peff@xxxxxxxx> writes: > On Wed, Jul 03, 2019 at 11:12:25AM +0200, SZEDER Gábor wrote: > >> On Mon, Jul 01, 2019 at 09:18:15AM -0400, Jeff King wrote: >> > diff --git a/t/t5618-alternate-refs.sh b/t/t5618-alternate-refs.sh >> > new file mode 100755 >> > index 0000000000..3353216f09 >> > --- /dev/null >> > +++ b/t/t5618-alternate-refs.sh >> > @@ -0,0 +1,60 @@ >> >> > +test_expect_success 'log --source shows .alternate marker' ' >> > + git log --oneline --source --remotes=origin >expect.orig && >> > + sed "s/origin.* /.alternate /" <expect.orig >expect && >> >> Unnecessary redirection, 'sed' can open that file on its own as well. > > Sure, but is there a compelling reason not to feed it as stdin? FWIW I do not think it is bad to redirect into a command at all ;-)