Hi, On Wed, 3 Jul 2019, Johannes Schindelin wrote: > Hi, > > On Tue, 2 Jul 2019, Johannes Schindelin wrote: > > > [...] I probably failed to mention another breakage, though...: > > > > not ok 54 - LC_ALL='C' git grep -P -f f -i 'Æ<NUL>[Ð]' a > > > > expecting success: > > >stderr && > > printf 'ÆQ[Ð]' | q_to_nul >f && > > test_must_fail env LC_ALL="C" git grep -P -f f -i a 2>stderr && > > test_i18ngrep ! 'This is only supported with -P under PCRE v2' stderr > > > > ++ printf 'ÆQ[Ð]' > > ++ q_to_nul > > ++ perl -pe 'y/Q/\000/' > > ++ command /usr/bin/perl -pe 'y/Q/\000/' > > ++ /usr/bin/perl -pe 'y/Q/\000/' > > ++ test_must_fail env LC_ALL=C git grep -P -f f -i a > > ++ case "$1" in > > ++ _test_ok= > > ++ env LC_ALL=C git grep -P -f f -i a > > Binary file a matches > > ++ exit_code=0 > > ++ test 0 -eq 0 > > ++ list_contains '' success > > ++ case ",$1," in > > ++ return 1 > > ++ echo 'test_must_fail: command succeeded: env LC_ALL=C git grep -P -f f -i a' > > test_must_fail: command succeeded: env LC_ALL=C git grep -P -f f -i a > > ++ return 1 > > error: last command exited with $?=1 > > > > There are three more test cases in that test script that fail similarly. See > > https://dev.azure.com/Git-for-Windows/git/_build/results?buildId=38852&view=ms.vss-test-web.build-test-results-tab&runId=1019770&resultId=101368&paneView=debug > > > > I ran out of time to look into this in more detail :-( > > I figured it out. It does not happen with your `ab/no-kwset` patch series > in isolation, it's only when it is merged into `pu`, and the culprit is > the bad interaction with the `js/mingw-use-utf8` branch. Whoops, it is the `kb/windows-force-utf8` branch instead. Ciao, Dscho
