On Tue, Jul 02, 2019 at 01:16:46PM -0700, Junio C Hamano wrote:
> Emily Shaffer <emilyshaffer@xxxxxxxxxx> writes:
>
> > + if ((flags & TRANSPORT_PUSH_ATOMIC) && err) {
> > + for (struct ref *it = remote_refs; it; it = it->next)
> > + switch (it->status) {
> > + case REF_STATUS_NONE:
> > + case REF_STATUS_UPTODATE:
> > + case REF_STATUS_OK:
> > + it->status = REF_STATUS_ATOMIC_PUSH_FAILED;
> > + default:
> > + continue;
> > + }
> > + }
>
>
> Let's write this more like so
>
> if ((flags & TRANSPORT_PUSH_ATOMIC) && err) {
> for (struct ref *it = remote_refs; it; it = it->next)
> switch (it->status) {
> case REF_STATUS_NONE:
> case REF_STATUS_UPTODATE:
> case REF_STATUS_OK:
> it->status = REF_STATUS_ATOMIC_PUSH_FAILED;
> break;
> default:
> break;
> }
> }
>
> to prevent compilers from giving "implicit fallthru" warnings.
Done, thanks.
