On 6/30/2019 2:35 PM, Carlo Arenas wrote: > On Fri, Jun 28, 2019 at 6:44 PM Derrick Stolee <stolee@xxxxxxxxx> wrote: >> >> On 6/28/2019 5:42 PM, Junio C Hamano wrote: >>> "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: >>> >>> Use of "signed char" would be OK, but this is a singleton instance >>> per repository, so I am not sure how much it matters to save a few >>> words here by not using the most natural "int" type. >> >> I'll use 'int' in v2. > > FWIW, this broke the build in (at least) Linux AArch64, unless the following > is applied on top of ds/early-access Thanks, Carlo, for reporting this. I'm glad we have someone running early builds on platforms with these special cases! I'm working on rerolling to use int. -Stolee
