On Wed, Jun 12, 2019 at 06:29:37AM -0700, Derrick Stolee via GitGitGadget wrote: > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh > index e80c1cac02..3b6fd0d728 100755 > --- a/t/t5318-commit-graph.sh > +++ b/t/t5318-commit-graph.sh > @@ -23,6 +23,14 @@ test_expect_success 'write graph with no packs' ' > test_path_is_file info/commit-graph > ' > > +test_expect_success 'close with correct error on bad input' ' > + cd "$TRASH_DIRECTORY/full" && > + echo doesnotexist >in && > + { git commit-graph write --stdin-packs <in 2>stderr; ret=$?; } && > + test "$ret" = 1 && This could be: test_expect_code 1 git commit-graph write --stdin-packs <in 2>stderr > + test_i18ngrep "error adding pack" stderr > +'