The 'add' subcommand is useless as it is mostly identical to the 'put' subcommand, so let's remove it. Helped-by: Derrick Stolee <stolee@xxxxxxxxx> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx> --- This and 2/2 follow this discussion about test coverage: https://public-inbox.org/git/CAP8UFD3VFdCUwDBTb9en22FO7HnWc4vgQ4h0hhariCB=om4b8A@xxxxxxxxxxxxxx/ t/helper/test-oidmap.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/t/helper/test-oidmap.c b/t/helper/test-oidmap.c index 7036588175..0acf99931e 100644 --- a/t/helper/test-oidmap.c +++ b/t/helper/test-oidmap.c @@ -47,21 +47,7 @@ int cmd__oidmap(int argc, const char **argv) if (p1) p2 = strtok(NULL, DELIM); - if (!strcmp("add", cmd) && p1 && p2) { - - if (get_oid(p1, &oid)) { - printf("Unknown oid: %s\n", p1); - continue; - } - - /* create entry with oidkey from p1, value = p2 */ - FLEX_ALLOC_STR(entry, name, p2); - oidcpy(&entry->entry.oid, &oid); - - /* add to oidmap */ - oidmap_put(&map, entry); - - } else if (!strcmp("put", cmd) && p1 && p2) { + if (!strcmp("put", cmd) && p1 && p2) { if (get_oid(p1, &oid)) { printf("Unknown oid: %s\n", p1); -- 2.22.0.464.g81fc6c5d4a.dirty
