Hi Junio, On Thu, 27 Jun 2019, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > >> > > If we would not have plenty of exercise for the PCRE2 build > >> > > options, I would be worried. But AFAICT the CI build includes > >> > > this all the time, so we're fine. > >> > > >> > Well, I'd feel safer if it were not "all the time", i.e. we know we > >> > are testing both sides of the coin. > >> > >> AFAIR at least the Linux32 job is built without PCRE2 by default. I > >> might be wrong on that, though... > > > > Actually, it seems that _all_ of the Linux builds in our Azure Pipeline > > compile without pcre2. It seems you have to pass `USE_LIBPCRE2=1` to > > `make`, and we do not do that in `ci/run-build-and-tests.sh` nor in > > `azure-pipelines.yml`. I do not even see that for the macOS builds. > > > > So we got PCRE2 covered only in the Windows build, it seems. > > OK, it sounds like we have sufficient coverage on both fronts. Maybe not. With the bug I uncovered that is _only_ triggering an error message if the PCRE2 in question does not support JIT'ed operations, I am a bit wary now. But I cannot really see a reasonable way to add those axes to the CI builds. Ciao, Dscho
