On Thu, Jun 27 2019, Johannes Schindelin wrote: > Hi Ævar, > > On Wed, 26 Jun 2019, Johannes Schindelin wrote: > >> On Wed, 26 Jun 2019, Ævar Arnfjörð Bjarmason wrote: >> >> > This speeds things up a lot, but as shown in the patches & tests >> > changed modifies the behavior where we have \0 in *patterns* (only >> > possible with 'grep -f <file>'). >> >> I agree that it is not worth a lot to care about NULs in search patterns. >> >> So I am in favor of the goal of this patch series. > > There seems to be a Windows-specific test failure: > https://dev.azure.com/gitgitgadget/git/_build/results?buildId=11535&view=ms.vss-test-web.build-test-results-tab&runId=28232&resultId=101315&paneView=debug > > The output is this: > > -- snip -- > not ok 5 - log --grep does not find non-reencoded values (latin1) > > expecting success: > git log --encoding=ISO-8859-1 --format=%s --grep=$utf8_e >actual > && > test_must_be_empty actual > > ++ git log --encoding=ISO-8859-1 --format=%s --grep=é > fatal: pcre2_match failed with error code -8: UTF-8 error: byte 2 top bits > not 0x80 > -- snap -- > > Any quick ideas? (I _could_ imagine that it is yet another case of passing > non-UTF-8-encoded stuff via command-line vs via file, which does not work > on Windows.) This is an existing issue that my patches just happen to uncover. I'm working on a v2 which'll fix it.
