Hi Junio, On Wed, 26 Jun 2019, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > > > This is the continuation of nd/sha1-name-c-wo-the-repository. In that > > series I sealed off one place in sha1-name.c that cannot walk trees > > from arbitrary repositories. With tree-walk.c taking 'struct > > repository *' directly, that check in there can now be removed. > > Thanks. > > With these queued on 'master', t7814 seems to become flaky (tried > running it with --stress, with and without these patches). Are we > touching a wrong index file in some codepaths or something? It's not flaky, as it fails consistently, and yes, we're touching the wrong repository in at least this one code path. I think I would have wished for a more careful conversion in this patch series, as it does touch critical code paths. Given that this bug was only caught by a failing CI build, it does make me wonder what other bugs are hidden and would slip into our code base just because of gaps in the code coverage. Ciao, Dscho
