Re: [RFC PATCH v2 04/13] walken: add handler to git_config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer <emilyshaffer@xxxxxxxxxx> wrote:
> For now, we have no configuration options we want to set up for
> ourselves, but in the future we may need to. At the very least, we
> should invoke git_default_config() for each config option; we will do so
> inside of a skeleton config callback so that we know where to add
> configuration handling later on when we need it.
>
> Signed-off-by: Emily Shaffer <emilyshaffer@xxxxxxxxxx>
> ---
> diff --git a/builtin/walken.c b/builtin/walken.c
> @@ -24,11 +25,36 @@ const char * const walken_usage[] = {
>  static void init_walken_defaults(void)
>  {
>         /*
> -        * We don't actually need the same components `git log` does; leave this
> -        * empty for now.
> +        * We don't use any other components or have settings to initialize, so
> +        * leave this empty.
>          */
>  }

Meh, I don't think this change has anything to do with this patch. If
the rewritten text is the one you prefer, then just introduce it like
that in patch 3/13 where the function itself was introduced.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux