Re: [PATCH/RFC] get_oid: new extended SHA-1 syntax to control resolution process

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 27, 2019 at 1:51 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
> > - <ref>@{literal} only accepts full ref. No turning "master" into
> >   "refs/heads/master".
>
> This is already doable by saying "refs/heads/master", isn't it?  Any
> ambiguous ones like a branch or a tag whose name is 'refs/heads/master'
> (i.e. refs/heads/refs/heads/master and refs/tags/refs/heads/master
> respectively) won't interfere once you use the explicit prefix refs/
> like so.  I'd rather not to see this one added.

If refs/heads/master does _not_ exist, then ref/heads/master can
resolve to refs/heads/refs/heads/master, which I think is unexpected.
"ref not found" error or something should be returned instead.
-- 
Duy



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux