"Marco Costalba" <mcostalba@xxxxxxxxx> writes: > On 7/16/07, Marco Costalba <mcostalba@xxxxxxxxx> wrote: >> On 7/16/07, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> > >> > I'd say making --show-message-size option incompatible with diff output >> > would be good enough futureproofing for now. >> > >> Oooops, I didn't see your post. >> >> I agree 100%, please tell me if doc it's clear enough or it would be >> better to clarify that "message log" it means only message and no diff >> content. >> > > Sorry to bother you again, but my English is very bad and I would like > to be clear. > > When i say no diff content I mean that git log --log-size -p it's a > perfect valid command but --log-size will make git print the size of > _only_ the log part, it means from the line after "log size xxx\n" > until the end of log message that can be '\0' (if no diff) or the > beginning of diff part. What I originally meant with my comment was to _error_ out if the user says "git log --log-size -p" (or "git show --log-size" without "-s"). But I guess it is probably fine, as long as it is crystal clear to the users that we do not do size for non log part. I still have this nagging feeling that this is an ugly workaround for Qt library's programming interface, though... - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
