On Thu, Jun 20, 2019 at 10:30:25AM +0200, Christian Couder wrote: > The fetch_if_missing global variable should be replaced as much > as possible by passing a flag to oid_object_info_extended(). > > The existing OBJECT_INFO_FOR_PREFETCH unfortunately conflates > both a "no fetch if missing" meaning with OBJECT_INFO_QUICK > which is about retrying packed storage. > > Let's disambiguate that by adding a new explicit > OBJECT_INFO_NO_FETCH_IF_MISSING flag. I think this patch is obsoleted by Stolee's 31f5256c82 (sha1-file: split OBJECT_INFO_FOR_PREFETCH, 2019-05-28), which I think just made it to master in the last day or so. There it's called OBJECT_INFO_SKIP_FETCH_OBJECT, so your 2/2 will need to be tweaked. -Peff