Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Eric,

On Tue, 18 Jun 2019, Eric Sunshine wrote:

> On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget
> <gitgitgadget@xxxxxxxxx> wrote:
> > In MSVC, the DEBUG constant is set automatically whenever compiling with
> > debug information.
> >
> > This is clearly not what was intended in cache-tree.c, so let's use a less
> > ambiguous constant there.
>
> s/constant/macro name/ would be clearer.

To me, "macro" always sounds as if it referred to executable code, or at
least to something that expands to code.

I went with s/constant/name/ instead.

Thanks,
Dscho

>
> > Signed-off-by: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
>




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux