On Tue, Jun 18, 2019 at 8:53 AM Jeff King <peff@xxxxxxxx> wrote: > > Thanks, this looks good to me. I fixed the system headers in xinclude.h, > but didn't think to check for individual C files including them. also noticed that after the refactoring some files will include a couple of headers twice (not an issue, though thanks to the header guards) but didn't send that patch to reduce the churn and avoid confusion. > I did a quick grep for similar cases, and didn't find any that I think > would be problematic. There were a few cleanups, below. would you mind if I add your 2 patches to a series and include that missing one?, that way I'll also have a chance to write a better commit message from my original change, including the other feedback I got as well Carlo PS. is there a recommendation on how to version a patch that move into a series that would be preferred?