On Tue, Jun 18, 2019 at 10:42:10AM +0200, Johannes Schindelin wrote: > > + if (!subspecs[0]) { > > + strbuf_addf(errbuf, > > + _("expected something after combine:")); > > Please squash this in, to pacify Coccinelle: > > -- snipsnap -- > diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c > index 5e5e30bc6a17..483ab512e24c 100644 > --- a/list-objects-filter-options.c > +++ b/list-objects-filter-options.c > @@ -150,7 +150,7 @@ static int parse_combine_filter( > int result = 0; > > if (!subspecs[0]) { > - strbuf_addf(errbuf, > + strbuf_addstr(errbuf, Thank you - fixed locally for the next re-roll.