On Sat, Jun 15, 2019 at 5:41 PM Christian Couder <christian.couder@xxxxxxxxx> wrote: > > On Fri, Jun 14, 2019 at 5:10 PM Jeff King <peff@xxxxxxxx> wrote: > > > > On Fri, Jun 14, 2019 at 08:35:04PM +0900, Masahiro Yamada wrote: > > > > > Perhaps, 'git interpret-trailers' should be changed > > > to recognize core.commentChar ? > > > > It looks like the trailer code does respect it, but the > > interpret-trailers program never loads the config. Does the patch below > > make your problem go away? > > It seems to me to be the right analysis and the right fix too. > > > I do wonder if the trailer code is correct to always respect it, though. > > For example, in "git log" output we'd expect to see commit messages from > > people with all sorts of config. I suppose the point is that their > > comment characters wouldn't make it into the commit object at all, so > > the right answer there is probably not to look for comment characters at > > all. > > Would you suggest an option, maybe called `--ignore-comments` to ignore them? Since 'git interpret-trailers' already ignores lines starting with '#', is this option true by default? > Thanks, > Christian. -- Best Regards Masahiro Yamada
