On Fri, Jun 14, 2019 at 1:07 PM Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote: > > On Thu, Jun 13, 2019 at 9:53 PM Duy Nguyen <pclouds@xxxxxxxxx> wrote: > > > > On Fri, Jun 14, 2019 at 7:30 AM Felipe Contreras > > <felipe.contreras@xxxxxxxxx> wrote: > > > > One way or the other, shouldn't my tests be merged? The issue is still > > > there, and it's nice to have tests for that. > > > > Is there any good reason to complete options when they are not going > > to work anyway (e.g. like checkout which needs $GIT_DIR)? Besides "it > > used to work before --git-completion-helper" which I don't consider a > > good reason given the maintenance tradeoff of --git-completion-helper. > > No, there is no good reason that I can think of, except checking the > arguments, which is precisely how I found out the issue; not something > I usually do. But a newcomer might not know what commands don't work > outside a git directory. > > But more importantly; is there a good enough reason not to? For me, yes. No extra work for me. > I seem to > recall to be annoyed by the fact that 'git command -h' failed on some > command with a fatal error. Similarly, I don't see any good reason why > 'git help clone' should ever fail. You could give the '-h' hack a try. It probably works for some, but I don't think it also works for things like 'git worktree add --git-completion-helper'. -- Duy
