Re: [PATCH v8 7/9] blame: add a fingerprint heuristic to match ignored lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



SZEDER Gábor <szeder.dev@xxxxxxxxx> writes:

>> +	git blame --ignore-rev $REV_2 --ignore-rev $REV_3 file | sed -e "$pick_author" >actual &&
>
> Please use an intermediate file between 'git blame' and the downstream
> 'sed' command, here and in other tests as well.
>
> This test script focuses specifically on 'git blame', but that pipe
> hides its exit code.

Good point on "this matters even more for 'blame' as the whole point
of t8014 _is_ about 'blame' running corretly".

Thanks.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux