On Tue, Jun 11, 2019 at 01:48:14PM -0700, Junio C Hamano wrote: > SZEDER Gábor <szeder.dev@xxxxxxxxx> writes: > > > Make sure that the previously displayed "Rebasing (N/M)" line is > > cleared by using the term_clear_line() helper function added in the > > previous patch. > > > > A couple of other rebase commands print similar messages, e.g. > > "Stopped at <abbrev-oid>... <subject>" for the 'edit' or 'break' > > commands, or the "Successfully rebased and updated <full-ref>." at the > > very end. These are so long that they practically always overwrite > > that "Rebasing (n/m)" progress line, but let's be prudent, and clear > > the last line before printing these, too. > > ... > > Note that this patch doesn't completely eliminate the possibility of > > similar garbled outputs, ... > > too soon, and it would either flicker or be invisible. > > The user of term_clear_line() in this patch always guard themselves > behind "we do not do this if we are producing verbose output," but > the proposed log message does not explain why they need to do so. In verbose mode there is no progress output that is overwritten and might need to be covered up.
