It may be illuminating to see which objects were not included within a given filter. This also demonstrates, since filter-spec "tree:1" is used, that the 'omitted' list contains all objects which are omitted, not just the first objects which were omitted - that is, it continues to dereference omitted trees and commits. This is part of a tutorial on performing revision walks. Signed-off-by: Emily Shaffer <emilyshaffer@xxxxxxxxxx> --- builtin/walken.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/builtin/walken.c b/builtin/walken.c index f2c98bcd6b..d93725ee88 100644 --- a/builtin/walken.c +++ b/builtin/walken.c @@ -137,6 +137,9 @@ static int walken_object_walk(struct rev_info *rev) { struct list_objects_filter_options filter_options = {}; struct oidset omitted; + struct oidset_iter oit; + struct object_id *oid = NULL; + int omitted_count = 0; oidset_init(&omitted, 0); printf("walken_object_walk beginning...\n"); @@ -172,9 +175,15 @@ static int walken_object_walk(struct rev_info *rev) walken_show_commit, walken_show_object, NULL, &omitted); } + /* Count the omitted objects. */ + oidset_iter_init(&omitted, &oit); + + while ((oid = oidset_iter_next(&oit))) + omitted_count++; + printf(_("Object walk completed. Found %d commits, %d blobs, %d tags, " - "and %d trees.\n"), commit_count, blob_count, tag_count, - tree_count); + "and %d trees; %d omitted objects.\n"), commit_count, + blob_count, tag_count, tree_count, omitted_count); return 0; } -- 2.22.0.rc1.311.g5d7573a151-goog