Hi Durant, Just a couple of small things: On Thu, Jun 06, 2019 at 09:38:54PM +0000, Durant Schoon wrote: > When the code comment in the zsh completion suggests that this file > should be copied to `~/.zsh`, many users might be misled to believe that > this refers to a file location. But it refers to a directory, and won't > work when it is a file. > > Let's just add a slash, to make it abundantly clear that this must be a > directory. > > (thank you to Johannes Schindelin for the suggested wording and title) Maybe this would be better incorporated as a Helped-by: or Suggested-by: tag at the bottom? > > Signed-off-by: B. Durant Schoon durant.schoon@xxxxxxxxx The email in your sign-off line should be wrapped in <>, i.e. it should be B. Durant Schoon <durant.schoon@xxxxxxxxx> Other than that, the patch looks fine to me. Thanks, Denton > --- > contrib/completion/git-completion.zsh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh > index 886bf95d1f594..0e63004e2613e 100644 > --- a/contrib/completion/git-completion.zsh > +++ b/contrib/completion/git-completion.zsh > @@ -11,8 +11,8 @@ > # > # zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh > # > -# The recommended way to install this script is to copy to '~/.zsh/_git', and > -# then add the following to your ~/.zshrc file: > +# The recommended way to install this script is to copy to '~/.zsh/_git/', > +# and then add the following to your ~/.zshrc file: > # > # fpath=(~/.zsh $fpath) > > > -- > https://github.com/git/git/pull/609
