Jeff Hostetler <git@xxxxxxxxxxxxxxxxx> writes: > On 5/28/2019 7:02 PM, Ævar Arnfjörð Bjarmason wrote: >> >> On Sun, May 19 2019, SZEDER Gábor wrote: >> ... >>> So let's rename all GIT_TR2* environment variables to GIT_TRACE2*, >>> before they make their way into a stable release. >> >> Good to see this land in 2.22.0. I wonder if we shouldn't take this >> further and rename trace2.* config to trace.*, and just re-use >> GIT_TRACE=1 instead of having GIT_TRACE2 as well, and have a >> GIT_TRACE_VERSION to switch between them. >> >> Then we could just switch in a future version. We've never promised what >> the trace format was going to look like, and the existing one isn't >> configurable (and we won't be making the v1 one...), so starting from >> the outset with "2" in config is unfortunate. >> >> We'd still have special snowflakes like e.g. GIT_TRACE_PACKET. >> >> OTOH we can just do this after the release if it's deemed a good idea, >> and just support trace2.* as aliases for trace.* for some amount of >> time, same for the env vars. > > I'm open to considering such a change while we're at it. I'm a bit against "while we're at it" part. Let's take the s/TR2/TRACE2/ change and stop at it for the upcoming release, without spending too much time on over-engineering the stuff that are primarily for developers. Thanks.
