Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Jonathan Tan wrote: > >> Currently, if any server options are specified during a protocol v2 >> fetch, server options will be sent before "command=fetch". Write server >> options to the request buffer in send_fetch_request() so that the >> components of the request are sent in the correct order. >> >> The protocol documentation states that the command must come first. The >> Git server implementation in serve.c (see process_request() in that >> file) tolerates any order of command and capability, which is perhaps >> why we haven't noticed this. This was noticed when testing against a >> JGit server implementation, which follows the documentation in this >> regard. >> >> Signed-off-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx> >> --- >> fetch-pack.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Oh, dear. Thanks for fixing it. > > Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> Yeah, looks good. Thanks. > > 6e98305985 (clone: send server options when using protocol v2, > 2019-04-12) is part of release candidates, but it looks like we caught > this in time to get the fix in before the release. > > Should we add an interop test for this to t/interop/? > > Thanks, > Jonathan
