On Sat, May 25, 2019 at 12:36 AM Todd Zullinger <tmz@xxxxxxxxx> wrote: > > Hi, > > Nguyễn Thái Ngọc Duy wrote: > > This should fix the diff tests failure on s360x. It's a serious problem > > and I plan to do something to prevent it from happening again. > > Thanks for looking at this! > > I applied this on top of master/2.22.0-rc1 and see a number > of compiler errors using gcc-9.1.1 with fedora's standard > compiler options for rpm builds. That last patch 4/3 is not meant to be applied. Yes I've seen similar compiler errors too. We have some cleaning up to do in order to build with the last one. But I think there are no other serious errors spotted by the last patch (there's one in builtin/column.c, but I think nobody uses it much, so we can fix it alter) -- Duy
