On Fri, May 24, 2019 at 11:49:28AM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Fri, May 24 2019, SZEDER Gábor wrote: > > > On Thu, May 23, 2019 at 07:48:33PM -0400, Derrick Stolee wrote: > >> On 5/23/2019 6:20 PM, SZEDER Gábor wrote: > >> > On Thu, May 23, 2019 at 11:54:22PM +0200, Ævar Arnfjörð Bjarmason wrote: > > > >> >> and since the commit graph doesn't include any commits outside of > >> >> packs you'd miss any loose commits. > >> > > >> > No, the commit-graph includes loose commits as well. > >> > >> Depends on how you build the commit-graph. > > > > Yeah; I just didn't want to go into details, hoping that this short > > reply will be enough to jog Ævar's memory to recall our earlier > > discussion about this :) > > To clarify (and I should have said) I meant it'll include only packed > commits in the mode Karl Ostmo invoked it in, as Derrick points out. No, even in that mode it will include loose objects as well, if it has to; that's what the "and closes under reachability" part of Derrick's reply means and that's what I showed in our earlier discussion at: https://public-inbox.org/git/20190322154943.GF22459@xxxxxxxxxx/
