Hi Junio, 林自均 <johnlinp@xxxxxxxxx> 於 2019年5月15日 週三 上午11:02寫道： > > Hi Junio, > > Junio C Hamano <gitster@xxxxxxxxx> 於 2019年5月15日 週三 上午8:48寫道： > > > > 林自均 <johnlinp@xxxxxxxxx> writes: > > > > > I was not talking about the messages in the editor session. I was > > > talking about "git commit" without "git add" anything. > > > > > > For example: > > > > > > ``` > > > $ touch newfile.txt > > > $ git commit > > > On branch master > > > Untracked files: > > > newfile.txt > > > > > > nothing added to commit but untracked files present > > > ``` > > > > > > My current patch is trying to add an empty line between > > > "Untracked files:" and "newfile.txt". > > > > I do not think that one is paged, so if you ask me, I'd say we > > shouldn't add an extra blank there. Is that message also reused in > > the editor session, or do two different codepaths produce a similar > > looking message, one for the above case direct to the terminal and > > the other for the editor session? > > The messages produced in wt-status.c seem to be reused in > both terminal and editor session. When I tried to modify the > messages in terminal, the ones in editor session will also > be modified accordingly. > > By the way, my new patch to remove extra blank line is here: > https://github.com/gitgitgadget/git/pull/196 > I am still waiting for someone to comment "/allow johnlinp". I've submitted the patch with the title [PATCH 1/1] status: remove the empty line after hints Please review if you are available. Thank you. Best, John Lin > > > > > But again... > > > > >> At the same time, I think I've been happy enough with the current > > >> output from both commands, so if you let me bikeshed freely, I'd > > >> probably pick "let's not change anything then" ;-) > >
