On Tue, May 21, 2019 at 05:34:02PM +0700, Duy Nguyen wrote: > > 2. There are hundreds of spots that need to swap out "repo->index" for > > "&repo->index". In the patch below I just did enough to compile > > archive-zip.o, to illustrate. :) > > You are more thorough than me. I saw #2 first and immediately backed > off (partly for a selfish reason: I have plenty of the_repo conversion > patches in queue and anything touching "repo" may delay those patches > even more). Yeah, that's true, it would be disruptive. > There's also #3 but this one is minor. So far 'struct repo' is more of > a glue of things. Embedding index_state in it while leaving > object_store, ref_store... pointers feels inconsistent and a bit > weird. It's not a strong reason for making index_state a pointer too, > but if we have to deal with pointers anyway... And yeah, I agree it would nice for it to all be consistent. Let's leave it at your patch for now, and we can think about refactoring this later. -Peff
