(dropping lkml and git-packagers) On Tue, May 21, 2019 at 3:31 PM Duy Nguyen <pclouds@xxxxxxxxx> wrote: > > The bug there is that the old opt_arg() code would be torelant to empty > > values. I noticed a similar change the other day with the --abbrev > > option, but didn't think it was worth noting. Maybe it's a more general > > problem, in both cases we had a blindspot in our tests. > > Hmm.. this one is different (at least it does not use opt_arg()). But > I'll double check. What is wrong with --abbrev? The code is simple enough for me to just compare line by line, and the only difference I can see is that if you pass --abbrev=12a, then the old code accepts "12" while the new one rejects. Granted, I said "no behavior change", but this may be pushing the limits a bit. But maybe you're seeing something else? Note that "git diff --abbrev" still uses the old, but different, parser in revision.c. parse_options() is only used for --abbrev with --no-index. -- Duy
