Re: Git config "ignorecase = true" has issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Anyone who likes to fix this issue?
-----------------------------------


Gesendet: Sonntag, 05. Mai 2019 um 12:11 Uhr
Von: "Ax Da" <discussion@xxxxxxx>
An: unlisted-recipients:;
Cc: git@xxxxxxxxxxxxxxx
Betreff: Re: Git config "ignorecase = true" has issues
Thanks for replying. Do you know how the query you mentioned ("Do we have a file named "file.txt" on disk?") is implemented in git?

I'd suggest to use the C++ Windows API function FindFirstFileW() and then manually compare the result with the queried file name, like:



bool fileExists(const WCHAR_T *fileName, bool ignoreCase)
{
  WIN32_FIND_DATAW fileData;
  bool fileExists = false;
int (*strCmp)(const wchar_t *string1, const wchar_t *string2, size_t count)
= ignoreCase ? _wcsnicmp : wcsncmp;
);

  if (FindFirstFileW(fileName, fileData) != INVALID_HANDLE_VALUE)
  {
    if (!strCmp(fileName, fileData.cFileName, wcsnlen(fileName, MAX_PATH) + 1)) fileExists = true;
 
    FindClose(fileData);
  }
 
  return fileExists;
}



---------------------------------------------------------------------------

Gesendet: Mittwoch, 24. April 2019 um 21:11 Uhr
Von: "Torsten Bögershausen" <tboegi@xxxxxx>
An: "Ax Da" <discussion@xxxxxxx>
Cc: git@xxxxxxxxxxxxxxx
Betreff: Re: Git config "ignorecase = true" has issues
On Fri, Apr 19, 2019 at 09:28:32PM +0200, Ax Da wrote:
>
> We're working on Windows machines and have been experiencing issues with the current implementation of Git with config setting "core.ignorecase = true" (which is the default on Windows machines and repositories created on Windows machines):
>
> Renaming files in a repository by only changing their case (changing a capital letter to its small equivalent and vice versa) is ignored by Git. Git retains the original case in the repository and all contributors will continue to see the ole file name which leads to confusion and issues with Open Source tools programmed to not ignore file name case.
>
> Currently there is no way to convey the new file name (only differing in case) to Git when "core.ignorecase = true".
>
> Hence, I propose to alter the behaviour of Git when "core.ignorecase = true": A repository's file name changes should be recognized as a RENAME operation and be propagated to the repository even when the new file name only differs from the old file name in case.

You can rename files like this:
git mv File.txt file.txt
git commit

and Git will record the changes.

The main problem is, that after the rename, and may be on another machine after a pull,
Git checks with the file system, if any updates in the working tree are needed.
In human speech, Git asks the file system:
Do we have a file named "file.txt" on disk ?
And Windows answers: Yes we have.
Even if the file is named "File.txt" and Git asks for "file.txt".

You can try it yourself.
Run
cat File.txt
under the Git shell (bash)
or
type File.txt
under cmd.exe

That is how it is.

If you really need the updated name "file.txt", you can delete all files in the worktree
rm -rf *
followed by
git reset --hard

But in any case, run
git status
before and make sure that your working tree is clean.

>
> Thanks,
> Axel Dahmen




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux