Change test code added in f434c083a0 ("send-email: add --no-cc, --no-to, and --no-bcc", 2010-03-07) which blindly copied a pattern from an earlier test added in 32ae83194b ("add a test for git-send-email for non-threaded mails", 2009-06-12) where the "$patches" variable was supplied more than once. As it turns out we didn't need more than one "$patches" for the test added in 32ae83194b either. The only tests that actually needed this sort of invocation were the tests added in 54aae5e1a0 ("t9001: send-email interation with --in-reply-to and --chain-reply-to", 2010-10-19). Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> --- t/t9001-send-email.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 1b18201ce2..13de44686b 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -1204,7 +1204,7 @@ test_expect_success $PREREQ 'no in-reply-to and no threading' ' --from="Example <nobody@xxxxxxxxxxx>" \ --to=nobody@xxxxxxxxxxx \ --no-thread \ - $patches $patches >stdout && + $patches >stdout && ! grep "In-Reply-To: " stdout ' @@ -1224,7 +1224,7 @@ test_expect_success $PREREQ 'sendemail.to works' ' git send-email \ --dry-run \ --from="Example <nobody@xxxxxxxxxxx>" \ - $patches $patches >stdout && + $patches >stdout && grep "To: Somebody <somebody@xxxxxx>" stdout ' @@ -1234,7 +1234,7 @@ test_expect_success $PREREQ '--no-to overrides sendemail.to' ' --from="Example <nobody@xxxxxxxxxxx>" \ --no-to \ --to=nobody@xxxxxxxxxxx \ - $patches $patches >stdout && + $patches >stdout && grep "To: nobody@xxxxxxxxxxx" stdout && ! grep "To: Somebody <somebody@xxxxxx>" stdout ' @@ -1245,7 +1245,7 @@ test_expect_success $PREREQ 'sendemail.cc works' ' --dry-run \ --from="Example <nobody@xxxxxxxxxxx>" \ --to=nobody@xxxxxxxxxxx \ - $patches $patches >stdout && + $patches >stdout && grep "Cc: Somebody <somebody@xxxxxx>" stdout ' @@ -1256,7 +1256,7 @@ test_expect_success $PREREQ '--no-cc overrides sendemail.cc' ' --no-cc \ --cc=bodies@xxxxxxxxxxx \ --to=nobody@xxxxxxxxxxx \ - $patches $patches >stdout && + $patches >stdout && grep "Cc: bodies@xxxxxxxxxxx" stdout && ! grep "Cc: Somebody <somebody@xxxxxx>" stdout ' @@ -1268,7 +1268,7 @@ test_expect_success $PREREQ 'sendemail.bcc works' ' --from="Example <nobody@xxxxxxxxxxx>" \ --to=nobody@xxxxxxxxxxx \ --smtp-server relay.example.com \ - $patches $patches >stdout && + $patches >stdout && grep "RCPT TO:<other@xxxxxx>" stdout ' @@ -1280,7 +1280,7 @@ test_expect_success $PREREQ '--no-bcc overrides sendemail.bcc' ' --bcc=bodies@xxxxxxxxxxx \ --to=nobody@xxxxxxxxxxx \ --smtp-server relay.example.com \ - $patches $patches >stdout && + $patches >stdout && grep "RCPT TO:<bodies@xxxxxxxxxxx>" stdout && ! grep "RCPT TO:<other@xxxxxx>" stdout ' -- 2.21.0.1020.gf2820cf01a